functional Archives - Taswar Bhatti

Was going through some legacy code recently and found a big for loop that had multiple switch statement inside. So being that I hate something that is fairly large, every method should be small and concise, I went along to refactor it to SRP.

This code is generic so you might see something like this in your code base also.

IEnumerable<Customer> allCustomers = Respository.GetAllCustomers();

IDictionary<string, string> payingCustomers = new Dictionary<string, string>();

IDictionary<string, string> nonPayingCustomers = new Dictionary<string, string>();

IDictionary<string, string> deadBeatCustomers = new Dictionary<string, string>();

foreach(var cust in allCustomers) 
{
  if(cust.Type == IGNORE)
    continue;
  
  switch(type) 
  {
    case A_TYPE: payingCustomer.Add(cust.Key, cust.Name);
	              break;
	case B_TYPE: nonPayingCustomer.Add(cust.Key, cust.Name);
	              break;
	case C_TYPE: deadBeatCustomer.Add(cust.Key, cust.Name);
	              break;
	}
}

IEnumerable<Customer

… Read the rest

Using LINQ to refactoring code into single responsibility principle SRP

Opinions are my own and not the views of my employer

My Book

LinkedIn

Archives